Repository navigation
fix(test): skip VM tests before booting extra VMs, unmount every node for fsck - #82
Merged
Merged
Conversation
… for fsck The three 3-VM tests and the concurrent directory test booted and mounted the VMs they need before checking NODE_COUNT. On a 2-node run VM 3 stayed mounted after they skipped, so fsck in the power-failure repair test saw its heartbeat and refused to run. That test also unmounted only VMs 1 and 2, so it failed on 3-node runs too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #72, "fsck Repair After Power Failure" fails on every 2-node VM run. Three 3-VM tests booted and mounted VM 3 before their NODE_COUNT skip, and fsck then refused to run because of VM 3's heartbeat (found by the per-node-journal session: 6 of 6 failures with VM 3 mounted, 2 of 2 passes without).
The tests now skip before booting anything, so no skipped test leaves a VM behind. The fsck test also unmounted only VMs 1 and 2, which broke 3-node runs, so it now unmounts and remounts every node.
Full 2-node VM suite on .68 (before rebasing onto #79): 57 passed, 0 failed. VM 3 never booted. The 3-node run is untested.
🤖 Generated with Claude Code